[Web Proxy] Use staging server for Web, Desktop when the "Use staging server" toggle is ON. #16432

Prince-Mendiratta · 2023-03-22T23:33:05Z

Details

With this PR, we are adding the ability to map all requests to production / staging API depending on the "Use staging server" toggle in user preferences. This change only affects the Development and Staging Environment.

Fixed Issues

$ #12315
PROPOSAL: #12315 (comment)

Tests

.env is not defined

Login to ND.
Go to Settings > Preferences > toggle the Use staging server toggle ON.
Go to Settings > Payments > Add payment Method > Bank Account.
Ensure that the Sandbox mode of Plaid is initiated. On Web and Desktop, this can be seen very clearly as the disclaimer is shown at the bottom. For native devices and mWeb, a good way to determine if we are in sandbox or not is the presence of the reCaptcha after selecting the bank institution. If it is present, then we are in production mode. If not, we are in sandbox mode. Another method to determine this on native and mWeb is that the flow redirects to the sandbox URL so it can be seen pretty clearly there as well.
Continue to add account normally in sandbox mode with any details. Notice that the account is added successfully after completing the flow.
Go to Settings > Preferences > toggle the Use staging server toggle OFF.
Go to Settings > Payments > Add payment Method > Bank Account.
Ensure that the Production mode of Plaid is initiated. Ways to confirm this are same as mentioned above.
Exit out of the production plaid flow
Open any chat.
Add a new attachment. Upload the attachment. Open it.
Ensure all action in step 11 happen seamlessly.

Expected Console Output

Note: There is a known issue in Android where when repeating the above tests will lead to an error. This will be tackled in this github issue.

Note 2: You might see an "Internal React error: Attempted to capture" error while testing but that is being tackled in #13917 and is not related to current changes.

Verify that no errors appear in the JS console

Offline tests

N/A, doesn't affect the offline functionality, should behave the same as expected behaviour when offline.

QA Steps

This doesn't affect the production behaviour. For staging,

Login to ND.
Go to Settings > Preferences > toggle the Use staging server toggle ON.
Go to Settings > Payments > Add payment Method > Bank Account.
Ensure that the Sandbox mode of Plaid is initiated. On Web and Desktop, this can be seen very clearly as the disclaimer is shown at the bottom. For native devices and mWeb, a good way to determine if we are in sandbox or not is the presence of the reCaptcha after selecting the bank institution. If it is present, then we are in production mode. If not, we are in sandbox mode. Another method to determine this on native and mWeb is that the flow redirects to the sandbox URL so it can be seen pretty clearly there as well.
Continue to add account normally in sandbox mode with any details. Notice that the account is added successfully after completing the flow.
Go to Settings > Preferences > toggle the Use staging server toggle OFF.
Go to Settings > Payments > Add payment Method > Bank Account.
Ensure that the Production mode of Plaid is initiated. Ways to confirm this are same as mentioned above.
Continue to add account normally in sandbox mode with any details. Notice that the account is added successfully after completing the flow.
Open any chat.
Add a new attachment. Upload the attachment. Open it.
Ensure all action in step 11 happen seamlessly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

without .env defined

Web

web-envless.mp4

Mobile Web - Chrome

android-chrome-envless.mp4

Mobile Web - Safari

ios-safari-envless.mp4

Desktop

desktop-envless.mp4

iOS

ios-envless.mp4

Android

android-envless.mp4

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

MelvinBot · 2023-03-22T23:33:11Z

@neil-marcellini @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Prince-Mendiratta · 2023-03-22T23:34:44Z

Requesting a review here from @kidroca @mountiny as well!

sobitneupane

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mountiny

Couple of questions

.env.example

config/proxyConfig.js

web/proxy.js

sobitneupane

IF .env is defined,
When UseStagingServer toggle is toggled on, 'STAGING_EXPENSIFY_URL' will be used from .env
When UseStagingServer toggle is toggled off, 'EXPENSIFY_URL' will be used from .env

EXPENSIFY_URL=https://www.expensify.com/
STAGING_EXPENSIFY_URL=https://staging.expensify.com/

@mountiny Will this configuration work for dev api(.com.dev) as well? I won't be able to test on dev api.

kidroca

Overall looks good

not sure whether we need the .env.example change

config/proxyConfig.js

web/proxy.js

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

src/libs/ApiUtils.js

neil-marcellini

If I turn on Use staging server with my dev .env file then all my api requests fail because they are sent to staging. I think we want to still send the requests to expensify.com.dev in that case. I believe that's why we reverted the PR last time.

Screen.Recording.2023-03-23.at.11.59.29.AM.mov

Prince-Mendiratta · 2023-03-23T19:02:30Z

@neil-marcellini I believe that in this case, if we make the following changes to the .env for internal employees, it should hit the dev domain even when the staging toggle is ON.

EXPENSIFY_URL=https://www.expensify.com.dev/
STAGING_EXPENSIFY_URL=https://www.expensify.com.dev/
STAGING_SECURE_EXPENSIFY_URL=https://secure.expensify.com.dev/

kidroca · 2023-03-23T19:03:47Z

If I turn on Use staging server with my dev .env file then all my api requests fail because they are sent to staging. I think we want to still send the requests to expensify.com.dev in that case. I believe that's why we reverted the PR last time.

Yeah, my last comment is about that: #16432 (comment)

So basically the toggle would do nothing for you - it won't change the API
In that case could you consider:

internal devs don't use the toggle (it's only about external devs that want to use fake bank accounts)
hide the toggle in DEV when the developer is not using a PROXY server

neil-marcellini · 2023-03-23T19:04:03Z

@Prince-Mendiratta Yeah but I think the point is we don't want to ask all internal engineers to make that change if we can avoid it.

Prince-Mendiratta · 2023-03-23T19:04:24Z

Another possibility that opens up is that we can match if the EXPENSIFY_URL ends with .dev or uses ngrok, we can hide/disable the Use Staging Server toggle altogether. What do you think?

kidroca · 2023-03-23T19:08:43Z

Question:
Is there an existing way internal developers are using the staging api?

I think you'd be changing some ngrok setting and you won't really use the toggle

neil-marcellini · 2023-03-23T19:13:21Z

Question:
Is there an existing way internal developers are using the staging api?

We make a backup of our .env file and then rename .env.staging to .env. Then we run the app on a native platform to get around CORS errors.

I'm fine with hiding the "use staging server" toggle when using internal development environment.

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta · 2023-03-23T19:34:57Z

@neil-marcellini @kidroca @sobitneupane updated, please have a look!

src/components/TestToolMenu.js

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

kidroca

✅ LGTM!

src/components/TestToolMenu.js

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

mountiny · 2023-03-24T16:37:15Z

Is there an existing way internal developers are using the staging api?
I think you'd be changing some ngrok setting and you won't really use the toggle

Yep, I just comment out the internal vm .env and add the staging one

mountiny

@Prince-Mendiratta Left one comment

web/proxy.js

Prince-Mendiratta · 2023-03-24T17:26:42Z

To conclude and summarise the changes that this PR introduces, we should define the environments, platforms and the actors.

Actor 1: External Developer. (Contributor)
Actor 2: Internal Developer. (Internal Employee)
Actor 3: QA team.

Environment 1: DEV. (Contributor)
Environment 2: Internal DEV. (Internal Employee) (using .dev domain or ngrok`)
Environment 3: Staging.
Environment 4: Production.

Platform 1: Web
Platform 2: mWeb
Platform 3: Desktop
Platform 4: Native

Now, the "Use staging toggle" is available only for Actor 1 and Actor 3 on Env 1 and 3, for all platforms.

For Web, there are 2 ways to run the app:

Using a web proxy. This is the option used by contributors. It routes the requests to a proxy server and depending on the toggle status, sends the request to the respective API endpoint. No .env changes are required.
Without the web proxy, directly sending the requests to the endpoint. This is done by internal employees. They do not make use of the staging server toggle and the use internal .dev domain for running the app. To use staging environment, direct .env changes are made.

For native apps,
They are built using the .env defined. If no env file is defined, it'll fall back to the default values, where the staging server toggle is working since native apps send requests directly to the endpoints.

For desktop, no proxy is used and the requests are sent directly to the endpoints.

So now, no changes need to be made anywhere to the .env file and it'll automatically respect the configuration of the staging server toggle.

mountiny · 2023-03-24T17:30:34Z

@Prince-Mendiratta Great comprehensive write-up, thank you very much 🙇

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta · 2023-03-24T18:55:40Z

Since the contents of the .env files do not affect the host anymore, we do not need tests with .env defined since they'll have the same behaviour. Updated tests accordingly.

mountiny

Thanks for working on this!

Prince-Mendiratta · 2023-03-27T09:11:19Z

Hi @neil-marcellini and all. Hope you guys had a great weekend. I think today can be the D-Day for this issue, can you please review it?

mountiny · 2023-03-27T10:02:45Z

@Prince-Mendiratta great job indeed. I think @neil-marcellini should be able to finish this one today!

neil-marcellini · 2023-03-27T10:06:59Z

Yes I will take a look soon!

sobitneupane · 2023-03-27T10:10:26Z

@mountiny What's your thought on this?

neil-marcellini

Ok I think this is good to go. Thank you.

neil-marcellini · 2023-03-27T15:23:50Z

@sobitneupane all you for the reviewer checklist.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2023-03-28T11:13:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-28T18:12:38Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.2.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-29T17:48:56Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.91-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Prince-Mendiratta added 3 commits March 23, 2023 03:44

use staging api when toggle is on

a26e93a

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

update sample env to reflect changes

58b6275

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

redirect chat attachments as well

e415cc2

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta requested a review from a team as a code owner March 22, 2023 23:33

melvin-bot bot requested review from neil-marcellini and sobitneupane and removed request for a team March 22, 2023 23:33

Prince-Mendiratta mentioned this pull request Mar 22, 2023

[HOLD for payment 2023-04-05] [$4000] Dev: Connect to bank account is not opening Sandbox page on dev server, redirects to real bank website #12315

Closed

sobitneupane reviewed Mar 23, 2023

View reviewed changes

mountiny assigned Prince-Mendiratta Mar 23, 2023

mountiny reviewed Mar 23, 2023

View reviewed changes

.env.example Outdated Show resolved Hide resolved

config/proxyConfig.js Outdated Show resolved Hide resolved

web/proxy.js Outdated Show resolved Hide resolved

sobitneupane reviewed Mar 23, 2023

View reviewed changes

kidroca reviewed Mar 23, 2023

View reviewed changes

config/proxyConfig.js Outdated Show resolved Hide resolved

kidroca reviewed Mar 23, 2023

View reviewed changes

web/proxy.js Outdated Show resolved Hide resolved

Prince-Mendiratta added 2 commits March 23, 2023 23:39

update staging pattern

85af209

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

remove .env.example updates

2f6f575

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

kidroca reviewed Mar 23, 2023

View reviewed changes

src/libs/ApiUtils.js Show resolved Hide resolved

neil-marcellini requested changes Mar 23, 2023

View reviewed changes

hide the staging server toggle for internal dev

4c352b8

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

kidroca reviewed Mar 24, 2023

View reviewed changes

src/components/TestToolMenu.js Outdated Show resolved Hide resolved

kidroca reviewed Mar 24, 2023

View reviewed changes

src/components/TestToolMenu.js Outdated Show resolved Hide resolved

Prince-Mendiratta added 2 commits March 24, 2023 15:08

inline ternary for staging toggle

2349ebf

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

update comment

45fc2b7

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

kidroca previously approved these changes Mar 24, 2023

View reviewed changes

sobitneupane reviewed Mar 24, 2023

View reviewed changes

src/components/TestToolMenu.js Outdated Show resolved Hide resolved

Prince-Mendiratta dismissed kidroca’s stale review via f155c63 March 24, 2023 12:01

correct condition

23c5848

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

mountiny reviewed Mar 24, 2023

View reviewed changes

web/proxy.js Outdated Show resolved Hide resolved

remove use of env vars in proxy

02b5da9

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

mountiny approved these changes Mar 24, 2023

View reviewed changes

mountiny requested a review from neil-marcellini March 24, 2023 19:01

kidroca approved these changes Mar 24, 2023

View reviewed changes

neil-marcellini approved these changes Mar 27, 2023

View reviewed changes

sobitneupane approved these changes Mar 28, 2023

View reviewed changes

neil-marcellini merged commit 3f66c68 into Expensify:main Mar 28, 2023

OSBotify mentioned this pull request Mar 28, 2023

Deploy Checklist: New Expensify 2023-03-28 #16632

Closed

30 tasks

Prince-Mendiratta deleted the dynamic-api branch April 1, 2023 10:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Web Proxy] Use staging server for Web, Desktop when the "Use staging server" toggle is ON. #16432

[Web Proxy] Use staging server for Web, Desktop when the "Use staging server" toggle is ON. #16432

Prince-Mendiratta commented Mar 22, 2023 •

edited

Loading

MelvinBot commented Mar 22, 2023

Prince-Mendiratta commented Mar 22, 2023

sobitneupane left a comment •

edited

Loading

mountiny left a comment

sobitneupane left a comment •

edited

Loading

kidroca left a comment

neil-marcellini left a comment

Prince-Mendiratta commented Mar 23, 2023 •

edited

Loading

kidroca commented Mar 23, 2023 •

edited

Loading

neil-marcellini commented Mar 23, 2023

Prince-Mendiratta commented Mar 23, 2023

kidroca commented Mar 23, 2023 •

edited

Loading

neil-marcellini commented Mar 23, 2023 •

edited

Loading

Prince-Mendiratta commented Mar 23, 2023

kidroca left a comment

mountiny commented Mar 24, 2023

mountiny left a comment

Prince-Mendiratta commented Mar 24, 2023 •

edited

Loading

mountiny commented Mar 24, 2023

Prince-Mendiratta commented Mar 24, 2023

mountiny left a comment

Prince-Mendiratta commented Mar 27, 2023

mountiny commented Mar 27, 2023

neil-marcellini commented Mar 27, 2023

sobitneupane commented Mar 27, 2023

neil-marcellini left a comment

neil-marcellini commented Mar 27, 2023

sobitneupane left a comment

OSBotify commented Mar 28, 2023

OSBotify commented Mar 28, 2023

OSBotify commented Mar 29, 2023

[Web Proxy] Use staging server for Web, Desktop when the "Use staging server" toggle is ON. #16432

[Web Proxy] Use staging server for Web, Desktop when the "Use staging server" toggle is ON. #16432

Conversation

Prince-Mendiratta commented Mar 22, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

without .env defined

MelvinBot commented Mar 22, 2023

Prince-Mendiratta commented Mar 22, 2023

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

kidroca left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

Prince-Mendiratta commented Mar 23, 2023 • edited Loading

kidroca commented Mar 23, 2023 • edited Loading

neil-marcellini commented Mar 23, 2023

Prince-Mendiratta commented Mar 23, 2023

kidroca commented Mar 23, 2023 • edited Loading

neil-marcellini commented Mar 23, 2023 • edited Loading

Prince-Mendiratta commented Mar 23, 2023

kidroca left a comment

Choose a reason for hiding this comment

mountiny commented Mar 24, 2023

mountiny left a comment

Choose a reason for hiding this comment

Prince-Mendiratta commented Mar 24, 2023 • edited Loading

mountiny commented Mar 24, 2023

Prince-Mendiratta commented Mar 24, 2023

mountiny left a comment

Choose a reason for hiding this comment

Prince-Mendiratta commented Mar 27, 2023

mountiny commented Mar 27, 2023

neil-marcellini commented Mar 27, 2023

sobitneupane commented Mar 27, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini commented Mar 27, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Mar 28, 2023

OSBotify commented Mar 28, 2023

OSBotify commented Mar 29, 2023

Prince-Mendiratta commented Mar 22, 2023 •

edited

Loading

sobitneupane left a comment •

edited

Loading

sobitneupane left a comment •

edited

Loading

Prince-Mendiratta commented Mar 23, 2023 •

edited

Loading

kidroca commented Mar 23, 2023 •

edited

Loading

kidroca commented Mar 23, 2023 •

edited

Loading

neil-marcellini commented Mar 23, 2023 •

edited

Loading

Prince-Mendiratta commented Mar 24, 2023 •

edited

Loading